cicd/login-action
1
0
Fork 0
mirror of https://github.com/docker/login-action.git synced 2025-10-31 10:10:09 +08:00
Code Issues Projects Wiki Activity

http_errors_to_retry -> http_codes_to_retry

Browse Source 
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
This commit is contained in:
Fedor Dikarev 2025-01-23 09:33:07 +01:00
parent 1a78bc10dc
commit 75fdabcf85
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -507,7 +507,7 @@ The following inputs can be used as `step.with` keys:
| `password` | String | | Password or personal access token for authenticating the Docker registry | | `password` | String | | Password or personal access token for authenticating the Docker registry |
| `ecr` | String | `auto` | Specifies whether the given registry is ECR (`auto`, `true` or `false`) | | `ecr` | String | `auto` | Specifies whether the given registry is ECR (`auto`, `true` or `false`) |
| `logout` | Bool | `true` | Log out from the Docker registry at the end of a job | | `logout` | Bool | `true` | Log out from the Docker registry at the end of a job |
| `http_errors_to_retry` | String | `408,500,502,504` | Comma separated list of HTTP error codes we want to retry | | `http_codes_to_retry` | String | `408,500,502,504` | Comma separated list of HTTP error codes we want to retry |
| `max_attempts` | String | `1` | Overall maximum number of attempts we will make trying to login (1 means no retries) | | `max_attempts` | String | `1` | Overall maximum number of attempts we will make trying to login (1 means no retries) |
| `retry_timeout` | String | `15` | Timeout between retries, in seconds | | `retry_timeout` | String | `15` | Timeout between retries, in seconds |

2
action.yml
View File

@ -24,7 +24,7 @@ inputs:
description: 'Log out from the Docker registry at the end of a job' description: 'Log out from the Docker registry at the end of a job'
default: 'true' default: 'true'
required: false required: false
http_errors_to_retry: http_codes_to_retry:
description: 'Comma separated list of HTTP error codes we want to retry' description: 'Comma separated list of HTTP error codes we want to retry'
default: '408,500,502,504' default: '408,500,502,504'
max_attempts: max_attempts:

4
src/context.ts
View File

@ -6,7 +6,7 @@ export interface Inputs {
password: string; password: string;
ecr: string; ecr: string;
logout: boolean; logout: boolean;
http_errors_to_retry: string[]; http_codes_to_retry: string[];
max_attempts: number; max_attempts: number;
retry_timeout: number; retry_timeout: number;
} }
@ -18,7 +18,7 @@ export function getInputs(): Inputs {
password: core.getInput('password'), password: core.getInput('password'),
ecr: core.getInput('ecr'), ecr: core.getInput('ecr'),
logout: core.getBooleanInput('logout'), logout: core.getBooleanInput('logout'),
http_errors_to_retry: core.getInput('http_errors_to_retry').split(','), http_codes_to_retry: core.getInput('http_codes_to_retry').split(','),
max_attempts: Number.parseInt(core.getInput('max_attempts')), max_attempts: Number.parseInt(core.getInput('max_attempts')),
retry_timeout: Number.parseInt(core.getInput('retry_timeout')) retry_timeout: Number.parseInt(core.getInput('retry_timeout'))
}; };

8
src/docker.ts
View File

@ -3,7 +3,7 @@ import * as core from '@actions/core';
import {Docker} from '@docker/actions-toolkit/lib/docker/docker'; import {Docker} from '@docker/actions-toolkit/lib/docker/docker';
export async function login(registry: string, username: string, password: string, ecr: string, http_errors_to_retry: string[], max_attempts: number, retry_timeout: number): Promise<void> { export async function login(registry: string, username: string, password: string, ecr: string, http_codes_to_retry: string[], max_attempts: number, retry_timeout: number): Promise<void> {
let succeeded: boolean = false; let succeeded: boolean = false;
for (let attempt = 1; attempt <= max_attempts && !succeeded; attempt++) { for (let attempt = 1; attempt <= max_attempts && !succeeded; attempt++) {
try { try {
@ -14,7 +14,7 @@ export async function login(registry: string, username: string, password: string
} }
succeeded = true; succeeded = true;
} catch (error) { } catch (error) {
if (attempt < max_attempts && isRetriableError(error.message, http_errors_to_retry)) { if (attempt < max_attempts && isRetriableError(error.message, http_codes_to_retry)) {
core.info(`Attempt ${attempt} out of ${max_attempts} failed, retrying after ${retry_timeout} seconds`); core.info(`Attempt ${attempt} out of ${max_attempts} failed, retrying after ${retry_timeout} seconds`);
await new Promise(r => setTimeout(r, retry_timeout * 1000)); await new Promise(r => setTimeout(r, retry_timeout * 1000));
} else { } else {
@ -34,8 +34,8 @@ export async function logout(registry: string): Promise<void> {
}); });
} }
function isRetriableError(error_message: string, http_errors_to_retry: string[]): boolean { function isRetriableError(error_message: string, http_codes_to_retry: string[]): boolean {
for (const err_code of http_errors_to_retry) { for (const err_code of http_codes_to_retry) {
if (error_message.includes('failed with status: ' + err_code)) { if (error_message.includes('failed with status: ' + err_code)) {
return true; return true;
} }

2
src/main.ts
View File

@ -8,7 +8,7 @@ export async function main(): Promise<void> {
const input: context.Inputs = context.getInputs(); const input: context.Inputs = context.getInputs();
stateHelper.setRegistry(input.registry); stateHelper.setRegistry(input.registry);
stateHelper.setLogout(input.logout); stateHelper.setLogout(input.logout);
await docker.login(input.registry, input.username, input.password, input.ecr, input.http_errors_to_retry, input.max_attempts, input.retry_timeout); await docker.login(input.registry, input.username, input.password, input.ecr, input.http_codes_to_retry, input.max_attempts, input.retry_timeout);
} }
async function post(): Promise<void> { async function post(): Promise<void> {