Commit Graph

14 Commits

Author SHA1 Message Date
Wataru Ashihara
097a640e79
[easyssh] fix: panic when using ssh-agent (appleboy/easyssh-proxy#42)
Before changes:

```sh
$ # This is what `keychain --eval --inherit any` does on Ubuntu.
$ # https://www.funtoo.org/Keychain
$ export SSH_AUTH_SOCK=/run/user/1000/keyring/ssh
$ go build example/ssh/ssh.go
$ ./ssh
panic: Can't run remote command: ssh: handshake failed: agent: client error: write unix @->/run/user/1000/keyring/ssh: use of closed network connection

goroutine 1 [running]:
main.main()
	/home/wsh/go/src/github.com/wataash/easyssh-proxy/example/ssh/ssh.go:32 +0x2d3
```

Error message `write unix @->/run/user/1000/keyring/ssh: use of closed network connection` comes from [`Write()`](https://github.com/golang/crypto/blob/2b6c08872f4/ssh/agent/client.go#L277) where `SSH_AUTH_SOCK` is already `Close()`ed.

After changes:

```sh
$ export SSH_AUTH_SOCK=/run/user/1000/keyring/ssh
$ go build example/ssh/ssh.go
$ ./ssh
github.com/wataash/easyssh-proxy
command-line-arguments
don is : true stdout is : total 640
drwxr-xr-x  68 wsh  wsh   4096 10月 16 21:25 .
drwxr-xr-x   3 root root  4096  9月 12 08:39 ..
drwxr-xr-x   2 wsh  wsh   4096  9月 20 20:48 .android
...
-rw-rw-r--   1 wsh  wsh    202  9月 12 19:51 .zshrc
 ;   stderr is : Identity added: /home/wsh/.ssh/id_rsa (/home/wsh/.ssh/id_rsa)
Identity added: /home/wsh/.ssh/id_ed25519 (wsh@wsh9b)

```

https://github.com/appleboy/drone-ssh/commit/9b697286281
2018-10-22 19:50:35 +09:00
Joshua Elliott
b5fc545ce2
[easyssh] Scan stdout and stderr in Stream in seperate goroutines. (appleboy/easyssh-proxy#41)
Fixes appleboy/easyssh-proxy#40.

Splits stdout and stderr scanning into seperate goroutines, and waits on both to finish through use of a wait group.

Also changed `res` chan to use empty structs as they take up less memory.

https://github.com/appleboy/drone-ssh/commit/e788e0d12bd
2018-10-22 19:50:35 +09:00
SebastienDorgan
442ce52def
[easyssh] Modify AuthMethod order (appleboy/easyssh-proxy#38)
* Modify AuthMethod order to be sure that user configuration is first in the list because ss.Dial only try the first method

https://github.com/appleboy/drone-ssh/commit/2a8dbafca51
2018-10-22 19:50:35 +09:00
SebastienDorgan
575df3ab1c
[easyssh] Change timeout type to time.Duration in Run and Stream Method (appleboy/easyssh-proxy#37)
* Change timeout type to time.Duration in Run and Stream Method

* Correct Connect method comment

https://github.com/appleboy/drone-ssh/commit/c193b89aa23
2018-10-22 19:50:02 +09:00
Bo-Yi Wu
cfa11e851a
[easyssh] make connect method as public. (appleboy/easyssh-proxy#36)
* make connect method as public.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* fix go path.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

* fix golint error.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>

https://github.com/appleboy/drone-ssh/commit/ca8e8301291
2018-10-22 19:50:02 +09:00
Diep Pham
71cbc0efd3
[easyssh] logs errors when parsing public keys (appleboy/easyssh-proxy#33)
* logs errors when parsing public keys

* adds missing newline

https://github.com/appleboy/drone-ssh/commit/b777a323265
2018-10-22 19:50:02 +09:00
Bo-Yi Wu
b5b13e8b72 upgrade easyssh to 1.1.6 (#81)
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2017-05-16 15:45:00 +08:00
Bo-Yi Wu
a7c37e0936
fix panic from easyssh-proxy
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2017-05-11 15:14:28 +08:00
Bo-Yi Wu
ceec42efdd
bump easyssh package.
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2017-05-10 21:37:48 +08:00
Bo-Yi Wu
b6c973ef1e fix: get exit code from ssh run command. (#78) 2017-05-09 09:38:31 +08:00
Bo-Yi Wu
c73e22e279 refactor: HostKeyCallback is the function type used for verifying server (#68) 2017-04-15 20:49:33 +08:00
Bo-Yi Wu
05b1a61165 refactor: upgrade easyssh to support DefaultConfig (#61) 2017-04-01 13:57:53 +08:00
Bo-Yi Wu
530df8d98b feat: Support proxy command. (#55) 2017-03-04 18:31:49 +08:00
Bo-Yi Wu
7e4e0224ee feat: Add time out flag. (#53)
* feat: Add time out flag.

* fix testing

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2017-03-04 17:50:05 +08:00